feat: bump jest to v27 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we land on this being a breaking change or not ? |
|
I think we said we don't a new major version as the breaking changes in Jest 27 do not affect our tests and by default |
|
Node 13 reached EOL in 2020-06-01 so we don't need to bump a major here I think. We do signal that we require Node >=12, and the ">" is slightly problematic here. I'll add a comment to the decision in meeting notes about why we aren't releasing this as a breaking change. |
varl
approved these changes
Aug 25, 2021
dhis2-bot
added a commit
that referenced
this pull request
Aug 25, 2021
# [7.5.0](v7.4.0...v7.5.0) (2021-08-25) ### Features * bump jest to v27 ([#616](#616)) ([618fd27](618fd27))
|
🎉 This PR is included in version 7.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
varl
added a commit
that referenced
this pull request
Aug 25, 2021
revert: "feat: bump jest to v27 (#616)"
dhis2-bot
added a commit
that referenced
this pull request
Aug 25, 2021
## [7.5.1](v7.5.0...v7.5.1) (2021-08-25) ### Reverts * "feat: bump jest to v27 ([#616](#616))" ([7733d14](7733d14))
dhis2-bot
added a commit
that referenced
this pull request
Aug 25, 2021
## [7.5.1-beta.1](v7.5.0...v7.5.1-beta.1) (2021-08-25) ### Reverts * "feat: bump jest to v27 ([#616](#616))" ([7733d14](7733d14))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest 27 introduced modern fake timers, which allow us to better mock timers as well as mock the system date/time.